Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twitter Icon to New Icon #1124

Open
nitesh2920 opened this issue Oct 6, 2024 · 12 comments
Open

Update Twitter Icon to New Icon #1124

nitesh2920 opened this issue Oct 6, 2024 · 12 comments

Comments

@nitesh2920
Copy link

Description:

The current Twitter icon is outdated. We need to replace it with the new Twitter icon to keep the website looking modern.

image

Expected Result:

The Twitter icon should be updated to reflect the latest icon.

I would like to work on this issue. please assign it to me!

@nitesh2920
Copy link
Author

Could this issue be labeled for Hacktoberfest 2024, @jaredgalanis and @marcoow? I would like to work on it.

@NullVoxPopuli
Copy link
Contributor

This whole repo is participating in hacktoberfest via to topic on the project home page 🎉

@nitesh2920
Copy link
Author

This whole repo is participating in hacktoberfest via to topic on the project home page 🎉

so I can directly raise a PR ?

@NullVoxPopuli
Copy link
Contributor

Yes, thank you! 🎉

@mansona
Copy link
Member

mansona commented Oct 7, 2024

for the record this change would need to happen on ember-styleguide: https://github.com/ember-learn/ember-styleguide/blob/master/addon/constants/es-footer.js#L3-L8

@nitesh2920
Copy link
Author

@mansona so i need to raise a PR on that repo ?

@mansona
Copy link
Member

mansona commented Oct 7, 2024

yes that's correct

@nitesh2920
Copy link
Author

nitesh2920 commented Oct 7, 2024

I have one query @mansona we can also update the svg of twitter logo class here then also the problem will solved.

@mansona
Copy link
Member

mansona commented Oct 7, 2024

well yes we could update the content of the twitter logo class but I would probably rename twitter-logo to x-logo and you can update the content 👍

You can also update the lines that I linked to 👍

@nitesh2920
Copy link
Author

@mansona, I understand your point. I will make the required changes and raise a PR.

@nitesh2920
Copy link
Author

nitesh2920 commented Oct 7, 2024

I have one question how can I see changes this in my local machine? I can't figure it out. Should I only need to run the test cases? @mansona

@nitesh2920
Copy link
Author

@mansona raise a PR here please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants