-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Twitter Icon to New Icon #1124
Comments
Could this issue be labeled for Hacktoberfest 2024, @jaredgalanis and @marcoow? I would like to work on it. |
This whole repo is participating in hacktoberfest via to topic on the project home page 🎉 |
so I can directly raise a PR ? |
Yes, thank you! 🎉 |
for the record this change would need to happen on ember-styleguide: https://github.com/ember-learn/ember-styleguide/blob/master/addon/constants/es-footer.js#L3-L8 |
@mansona so i need to raise a PR on that repo ? |
yes that's correct |
well yes we could update the content of the twitter logo class but I would probably rename You can also update the lines that I linked to 👍 |
@mansona, I understand your point. I will make the required changes and raise a PR. |
I have one question how can I see changes this in my local machine? I can't figure it out. Should I only need to run the test cases? @mansona |
Description:
The current Twitter icon is outdated. We need to replace it with the new Twitter icon to keep the website looking modern.
Expected Result:
The Twitter icon should be updated to reflect the latest icon.
I would like to work on this issue. please assign it to me!
The text was updated successfully, but these errors were encountered: