-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: remove usage of ember-data #1078
Comments
I'm in favor of this. I think ember-data is unique enough where it al so deserves its own docs, so it can explain
data is too complicated of a topic (imo) to just be sprinkled here and there without deep dives. |
@NullVoxPopuli are you talking here about removing/extracting ED content from the website? Because my point described with this issue was to remove ED from the internal implementation of the website! |
ah I see -- I'm in favor of both. |
Suggesting to remove the use of ember-data here, due to these reasons:
Suggested alternative
allowAppImports
feature of ember-auto-import to allow (lazily) importing our own code/data, and enable integration of custom webpack pluginsawait import('../data/users')
Notes
This idea came up in my mind when I was looking to upgrade ember-responsive-image to the latest (beta) version, which has done the shift to pull-based imports and shifting build-integration from legacy broccoli hooks to native webpack loaders. So instead of referencing images by string-based globally unique file names, you would import them explicitly. But this doesn't play well with the setup we have here currently, as images are referenced by their filenames as strings in the generated json, and that broccoli-generated json data does not allow to have imports or take part in the webpack build. The alternative suggested above would make this very easy however! This alone wouldn't justify doing this shift, but I think it makes sense on its own given the arguments laid out above, unrelated to any specific concerns of integrating the new version of the addon. "Killing two birds with one stone"
The text was updated successfully, but these errors were encountered: