Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't recognize Glimmer Components via runtime telemetry #394

Open
gitKrystan opened this issue May 31, 2023 · 0 comments
Open

Doesn't recognize Glimmer Components via runtime telemetry #394

gitKrystan opened this issue May 31, 2023 · 0 comments

Comments

@gitKrystan
Copy link
Contributor

gitKrystan commented May 31, 2023

This codemod currently uses analyzeEmberObject exported from ember-codemods-telemetry-helpers. It turns out that the analyzeEmberObject implementation is very specific to the native class codemod that it was extracted from, and thus it only recognizes EmberObject and its descendants when determining the type property:

https://github.com/ember-codemods/ember-codemods-telemetry-helpers/blob/cf2bb9be57bd5cc454c73c61217db64d76c0dbed/lib/gather/analyze-ember-object.js#L158-L171

To fix this, we should replace analyzeEmberObject with our own implementation.

This is probably the root cause for:
#101

It might be related to:
#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant