Skip to content

Commit d18b904

Browse files
committed
Add additional examples and fix lint errors
1 parent b689a05 commit d18b904

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

docs/rules/no-empty-glimmer-component-classes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ class MyComponent extends Component {
3131
## References
3232

3333
* [Glimmer Components - Octane Upgrade Guide](https://guides.emberjs.com/release/upgrading/current-edition/glimmer-components/)
34-
* [Glimmer Components RFC](https://emberjs.github.io/rfcs/0416-glimmer-components.html)
34+
* [Glimmer Components RFC](https://emberjs.github.io/rfcs/0416-glimmer-components.html)

lib/rules/no-empty-glimmer-component-classes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ module.exports = {
1515
description: 'disallow empty backing classes for Glimmer components',
1616
category: 'Ember Octane',
1717
recommended: false,
18-
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/no-empty-glimmer-component-classes.md',
18+
url:
19+
'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/no-empty-glimmer-component-classes.md',
1920
},
2021
fixable: null,
2122
schema: [],

tests/lib/rules/no-empty-glimmer-component-classes.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ ruleTester.run('no-empty-glimmer-component-classes', rule, {
2727
return this.args.bar + this.args.baz;
2828
}
2929
}`,
30+
'class MyComponent extends NotAGlimmerComponent {}',
3031
],
3132
invalid: [
3233
{
@@ -36,5 +37,12 @@ ruleTester.run('no-empty-glimmer-component-classes', rule, {
3637
output: null,
3738
errors: [{ message: ERROR_MESSAGE, type: 'ClassDeclaration' }],
3839
},
40+
{
41+
code: `import Component from '@glimmer/component';
42+
43+
class MyComponent extends Component { /* foo */ }`,
44+
output: null,
45+
errors: [{ message: ERROR_MESSAGE, type: 'ClassDeclaration' }],
46+
},
3947
],
4048
});

0 commit comments

Comments
 (0)