Skip to content

Commit 52e0989

Browse files
authored
Merge pull request #864 from jaydgruber/issue-849
Fix default value of `ignoreClassic` option to be true for `no-computed-properties-in-native-classes` rule
2 parents 4c3cfad + 2dd67bb commit 52e0989

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

lib/rules/no-computed-properties-in-native-classes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ module.exports = {
5353
},
5454

5555
create(context) {
56-
const ignoreClassic = context.options[0] && context.options[0].ignoreClassic;
56+
const ignoreClassic = !context.options[0] || context.options[0].ignoreClassic;
5757
let computedNodes = [];
5858

5959
const report = function (node) {

tests/lib/rules/no-computed-properties-in-native-classes.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,17 @@ ruleTester.run('no-computed-properties-in-native-classes', rule, {
107107
},
108108
],
109109
},
110+
{
111+
code: `
112+
import { computed } from '@ember/object';
113+
import Component from '@ember/component';
114+
import classic from 'ember-classic-decorator';
115+
116+
@classic
117+
export default class MyComponent extends Component {}
118+
`,
119+
options: [], // default options should be: [{ ignoreClassic: true }]
120+
},
110121

111122
// Unrelated import statements:
112123
"import EmberObject from '@ember/object';",

0 commit comments

Comments
 (0)