Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't work as dependencies #98

Closed
villander opened this issue Jan 5, 2018 · 4 comments
Closed

Don't work as dependencies #98

villander opened this issue Jan 5, 2018 · 4 comments

Comments

@villander
Copy link

villander commented Jan 5, 2018

ember-fecth does not work in my consumer app with Fastboot enabled, when I put ember-fetch as dependencies in my addon

cosumer app - https://github.com/villander/ember-mvp
addon - https://github.com/villander/ember-apollo-client/blob/apollo-client-2.0/package.json#L34

looks like ember-fetch specifically doesn’t work with fastboot when it’s a nested dependency
because its updateFastBootManifest() method is never called

the question is what happens when you wind up calling that hook multiple times?
like if ember-mvp and ember-apollo-client both have ember-fetch installed, does it get called twice?

is it ember-fetch’s responsibility to guard against that?

@stefanpenner
Copy link
Collaborator

@kratiahuja got any cycles?

@villander
Copy link
Author

@kratiahuja can you help us with that? or some hint of how to solve it, I can work on it if I know the cause

@dfreeman
Copy link

dfreeman commented Jun 8, 2018

I opened up ember-fastboot/ember-cli-fastboot#597 to try and start driving toward a solution here. @stefanpenner @kratiahuja would love to get your thoughts

@xg-wang
Copy link
Member

xg-wang commented Sep 7, 2018

Close as mentioned in #126
We can re-open if we can leverage new API for a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants