Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning introduced by plugins not caching, is not as actionable as it could #92

Open
stefanpenner opened this issue Aug 18, 2016 · 11 comments

Comments

@stefanpenner
Copy link
Contributor

https://github.com/ember-cli/ember-cli-htmlbars/pull/90/files#diff-fc695117845e9b76dfb1841d2221ac7cR133

should include a URL to "how to fix it".

@stefanpenner
Copy link
Contributor Author

Also, we need docs here explaining how to fix this.

@rwjblue
Copy link
Member

rwjblue commented Aug 19, 2016

FWIW, the AST plugin system is not public API. I didn't document this for that reason.

@tim-evans
Copy link

It's documented on the home page. (.___________ .)

I'm currently using this in my addon https://github.com/tim-evans/ember-page-title, and am encountering this error.

@rwjblue
Copy link
Member

rwjblue commented Sep 15, 2016

@tim-evans - What home page?

@tim-evans
Copy link

Oh, the README. I figured what I was doing wrong :)

@tim-evans
Copy link

Sorry if I'm being a bother~

@jzaefferer
Copy link

I'm not sure what release/update exactly introduced it, but I'm not getting these warnings on my project:

DEPRECATION: ember-cli-htmlbars-inline-precompile is opting out of caching due to an AST plugin that does not provide a caching strategy: `ember-css-modules`.
DEPRECATION: ember-cli-htmlbars-inline-precompile is opting out of caching due to an AST plugin that does not provide a caching strategy: `transform-liquid-with-as-to-hash`.
DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `ember-css-modules`.
DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `transform-liquid-with-as-to-hash`.
DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `transform-liquid-with-as-to-hash`.

There's two different modules complaining about this issue, caused by two other modules. I didn't find any open issues for the other modules...

Does anybody have a hint how to fix this? That could be a starting point for proper docs.

@tim-evans
Copy link

I think it's using the wrong hook in index.js for those addons:

See ember-cli/ember-page-title@8918d70 for what I did to fix it.

@jzaefferer
Copy link

Thanks for the link, but as a user of those addons (not an author), that doesn't help me. I've got no idea what's going on in that code...

@stefanpenner
Copy link
Contributor Author

@jzaefferer please open an issue on the offending add-on.

@jzaefferer
Copy link

Filed on for ember-css-modules: salsify/ember-css-modules#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants