Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colocation babel plugin drops class decorators #442

Open
ef4 opened this issue Jan 23, 2020 · 2 comments
Open

Colocation babel plugin drops class decorators #442

ef4 opened this issue Jan 23, 2020 · 2 comments

Comments

@ef4
Copy link
Contributor

ef4 commented Jan 23, 2020

With an input like

import hbs from 'ember-cli-htmlbars-inline-precompile';
const __COLOCATED_TEMPLATE__ = hbs`{{yield}}`;
export default @dec class {}

The class decorator @dec gets dropped:

import hbs from 'ember-cli-htmlbars-inline-precompile';
const __COLOCATED_TEMPLATE__ = hbs`{{yield}}`;
export default Ember._setComponentTemplate(__COLOCATED_TEMPLATE__, class {});

See example https://astexplorer.net/#/gist/4fb9360091ca6422ca0f9e4ee8ef9505/90046a397d94a8ccf8e97c17fd4f2d0cb867a129

I think all that is required to fix is to pass defaultExportDeclaration.decorators as the fourth argument to t.classExpression().

Copy link
Member

rwjblue commented Feb 6, 2020

awesome, thank you for reporting @ef4!

Copy link
Member

rwjblue commented Feb 6, 2020

We should also confirm that we don't loose comments (IIRC comments are sometimes attached to the node like this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants