Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher Update need some help #65

Open
anacinone opened this issue Feb 18, 2023 · 4 comments
Open

Launcher Update need some help #65

anacinone opened this issue Feb 18, 2023 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@anacinone
Copy link

When a launcher downloads an update, the new executable file overrides the old one.
If the update process is interrupted or fails, the launcher can be left with a corrupted executable, making it impossible to run.
We need a more reliable way to update itself like
-a file swap after the download.
-patch download and overrides everything.

@babanini95
Copy link

In my case, I make my own PatcherUpdater. I make it download all the new Launcher files in a temporary folder and cut it to my Launcher folder once the download is completed.

@emanzione emanzione self-assigned this May 11, 2023
@emanzione emanzione added bug Something isn't working enhancement New feature or request labels May 11, 2023
@kygodev
Copy link

kygodev commented Jul 26, 2023

Can confirm this bug. It was not present in older versions.

@emanzione
Copy link
Owner

I am thinking about the possible implications of a possible fix for this. The fix would be to download everything in a temporary folder, then replace all the files when we are sure that all the downloads have been completed successfully.

However, this requires more free disk space, precisely it requires twice the Launcher's size.

Not sure if this is a real problem, but I am thinking about implementing this behavior behind an opt-in flag in the LauncherUpdater.

What do you think?

@kygodev
Copy link

kygodev commented Jul 26, 2023

Would be nice i think. Because i dont know if its a game related problem or the patcher is corupting the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants