Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make helm-ag-ignore-patterns works with rg. #388

Open
zw963 opened this issue Mar 30, 2022 · 4 comments
Open

make helm-ag-ignore-patterns works with rg. #388

zw963 opened this issue Mar 30, 2022 · 4 comments

Comments

@zw963
Copy link

zw963 commented Mar 30, 2022

Because ag use --ignore PATTERN to Ignore files/directories whose names match this pattern. Literal file and directory names are also allowed.

But, when use with rg, we have to hard-code following function to support it.

e.g.

(defun helm-ag--construct-ignore-option (pattern)
  "Not documented, PATTERN."
  (concat "--glob=" pattern))  ;; => we have to change `--ignore` to `--glob=` to support rg

;; now, rg can work with ignore pattern.
 '(helm-ag-ignore-patterns '("!*~" "!#*#" "!*.min.*" "!TAGS" "!tags" "!.git/"))
@pataquets
Copy link

@zw963 You might be interested in the thread at #16200, which might provide you some useful info.
Check it out and see if it helps. Just updating helm-ag fixed it for me.

@zw963
Copy link
Author

zw963 commented Mar 11, 2024

where is the #16200 ?

@bostonaholic
Copy link

where is the #16200 ?

@zw963, here: syl20bnr/spacemacs#16200

@zw963
Copy link
Author

zw963 commented Mar 12, 2024

where is the #16200 ?

@zw963, here: syl20bnr/spacemacs#16200

Cool, nice, will try it later, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants