Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $ from face names for interoperability with treesit #780

Closed
zonuexe opened this issue May 27, 2024 · 0 comments · Fixed by #781
Closed

Remove $ from face names for interoperability with treesit #780

zonuexe opened this issue May 27, 2024 · 0 comments · Fixed by #781

Comments

@zonuexe
Copy link
Member

zonuexe commented May 27, 2024

$ is fine as a Lisp symbol, but there is a problem with compatibility with treesit, so we will rename them.

  • php-$this → php-this
  • php-$this-sigil → php-this-sigil

refs emacs-php/php-ts-mode#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove $ from facename for interop with treesit emacs-php/php-mode
1 participant
@zonuexe