Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-type-list-kwds instances inside strings are fontified #493

Open
phil-s opened this issue Jan 7, 2019 · 1 comment
Open

c-type-list-kwds instances inside strings are fontified #493

phil-s opened this issue Jan 7, 2019 · 1 comment
Assignees
Labels

Comments

@phil-s
Copy link
Contributor

phil-s commented Jan 7, 2019

e.g. my PHP file contains $foo = 'Title to use when rendering.'; and the word when is highlighted, because it is being treated as the <thing> in a use <thing> declaration.

I expect the relevant code is:

(c-lang-defconst c-type-list-kwds
  php '("new" "use" "implements" "extends" "namespace" "instanceof" "insteadof"))

A bit of experimenting suggests that such things only occur for c-type-list-kwds and potentially c-postfix-decl-spec-kwds (which is a subset of the former), but do not happen for the other uses of c-lang-defconst.

Is this just Expected Behaviour from the parent mode, or can php-mode do something to prevent such keywords being fontified inside strings?

I notice that this does not happen inside comments.

@phil-s phil-s changed the title PHP keywords inside strings are fontified c-type-list-kwds instances inside strings are fontified Jan 7, 2019
@zonuexe zonuexe self-assigned this Jan 9, 2019
@zonuexe zonuexe added the Bug label Jan 9, 2019
@zonuexe
Copy link
Member

zonuexe commented Jan 9, 2019

@phil-s Thank you for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants