Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #27 fails on emacs27 #426

Closed
krydos opened this issue Feb 26, 2018 · 2 comments
Closed

test #27 fails on emacs27 #426

krydos opened this issue Feb 26, 2018 · 2 comments
Assignees
Labels

Comments

@krydos
Copy link

krydos commented Feb 26, 2018

Hi,
I'm in current Emacs master branch (GNU Emacs 27.0.50, Ubuntu) and when I run make test (in php-mode repo) I'm getting this error for php-mode-test-issue-27.

Click to see the log
  Test php-mode-test-issue-27 backtrace:                                         
  signal(wrong-type-argument (stringp nil))                                    
  c-syntactic-re-search-forward("[      \n[:?;{=*/%&|,<>!@+-]" nil t t)        
  c-forward-label()                                                            
  c-guess-basic-syntax()                                                       
  c-indent-region(1 500 nil)                                                   
  php-cautious-indent-region(1 500)                                            
  indent-region(1 500)                                                         
  (let ((inhibit-message t)) (indent-region (point-min) (point-max)))          
  (progn (insert-file-contents (expand-file-name "issue-27.php" php-mo         
  (unwind-protect (progn (insert-file-contents (expand-file-name "issu                                                                                         
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn         
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b         
  (lambda nil (let ((temp-buffer (generate-new-buffer " *temp*"))) (sa         
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test         
  ert-run-test(#s(ert-test :name php-mode-test-issue-27 :documentation         
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test          
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #         
  ert-run-tests-batch(nil)                                                     
  ert-run-tests-batch-and-exit()                                               
  command-line-1(("-L" "." "-l" "php-mode-test.el" "-f" "ert-run-tests         
  command-line()                                                               
  normal-top-level()                                                           
Test php-mode-test-issue-27 condition:                                         
    (wrong-type-argument stringp nil)                                          
   FAILED  31/52  php-mode-test-issue-27

I was trying to find the reason of it but I didn't succeed due to my pure knowledge. As far as I understand the whole emacs27 branch fails the test but I'm not really sure.

I would like to send pull request with pleasure if someone can help me to figure out why the test fails.

P.S.
I have to mention that the issue tested with php-mode-test-issue-27 is NOT happening actually. Indentation works perfectly.

@krydos krydos changed the title test #27 issue on emacs27 test #27 fails on emacs27 Feb 26, 2018
@zonuexe
Copy link
Member

zonuexe commented Feb 28, 2018

@krydos Thanks for reporting.

@zonuexe
Copy link
Member

zonuexe commented Apr 7, 2018

@krydos This problem was solved in #453. Thanks!

@zonuexe zonuexe closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants