Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolic link to eask executable is not working #125

Closed
conao3 opened this issue Feb 21, 2023 · 5 comments
Closed

symbolic link to eask executable is not working #125

conao3 opened this issue Feb 21, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@conao3
Copy link

conao3 commented Feb 21, 2023

Hi, I usually build something softwares in ~/.local/work/xxx and ln from ~/.local/bin/.
This workflow is works well but eask executable occur error.

cd ~/.local/work
git clone https://github.com/emacs-eask/cli eask
cd eask
npm install
cd ~/.local/bin
ln -s ../work/eask/bin/eask
eask

will shows below error.

$ eask
node:internal/modules/cjs/loader:1063
  throw err;
  ^

Error: Cannot find module '/home/conao/.local/eask'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1060:15)
    at Module._load (node:internal/modules/cjs/loader:905:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v19.6.0

I think the executable should work regardless of the current directory. How about it?

@jcs090218
Copy link
Member

The issue came from unresolved symbolic link path:

cli/bin/eask

Lines 20 to 21 in 00e2646

BASEDIR=$(dirname "$0")
node "$BASEDIR/../eask" "$@"

I think @Fuco1 is trying to resolve this issue in #24. Sorry, I am not a bash expert, so I don't know how to resolve symbolic link issues both in Linux and macOS at the same time. 😓 But I would definitely like to resolve this issue.

@jcs090218
Copy link
Member

jcs090218 commented Feb 21, 2023

Ah, I think I've found the solution, it should be resolved in #126.

Let me know if it works. Thank you!

@conao3
Copy link
Author

conao3 commented Feb 22, 2023

wow! Thanks, the issue I mentioned is solved!

@conao3
Copy link
Author

conao3 commented Feb 22, 2023

BTW, eask looks very good to me and I will use it!

@jcs090218
Copy link
Member

Awesome! I've spent so much time on this! Thank you for using it! ❤️ 🚀 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants