Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat 'First ... Last' and 'Last, First ...' the same #532

Open
rudolf-adamkovic opened this issue Jan 17, 2022 · 5 comments
Open

Treat 'First ... Last' and 'Last, First ...' the same #532

rudolf-adamkovic opened this issue Jan 17, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@rudolf-adamkovic
Copy link

Some test cases:

  • author = {Knuth, Donald Ervin} = Knuth
  • author = {Knuth, Donald E.} = Knuth
  • author = {Donald Ervin Knuth} = Knuth
  • author = {Donald E. Knuth} = Knuth
  • author = {Donald Knuth} = Knuth
  • author = {D. Knuth} = Knuth
  • author = {Knuth} = Knuth
  • author = {{Knuth, Not}} = Knuth, Not
  • author = {{Not Knuth}} = Not Knuth
@rudolf-adamkovic rudolf-adamkovic added the bug Something isn't working label Jan 17, 2022
@bdarcus
Copy link
Contributor

bdarcus commented Jan 18, 2022

Notes, for whoever gets to looking at this more closely.

Right now, citar-display-transform-functions strips the braces from names before citar-shorten-names sees them.

So that would need refactoring.

Also, two requirements:

  1. I don't want this to be focused only on personal names, as the title of this issue suggests. It has to work for corporate names too (as it does now). Also ...
  2. Must work reasonably well with CSL JSON; not only for bib(la)tex. That format does have informal support for tagging subfield markup for this use case, though I'm not sure if parsebib-parse preserves that or not.

PS - I changed the label from bug to enhancement. As I said elsewhere, I don't consider this a bug.

@bdarcus bdarcus added enhancement New feature or request and removed bug Something isn't working labels Jan 18, 2022
@aikrahguzar
Copy link
Contributor

aikrahguzar commented Jan 25, 2022

Notes, for whoever gets to looking at this more closely.

Right now, citar-display-transform-functions strips the braces from names before citar-shorten-names sees them.

So that would need refactoring.

This part seems simple, we can just change the order of two functions is the citar-display-transform-functions, that way citar-clean-string will run after citar-shorten-names.

@bdarcus
Copy link
Contributor

bdarcus commented Apr 13, 2022

This part seems simple, we can just change the order of two functions is the citar-display-transform-functions, that way citar-clean-string will run after citar-shorten-names.

So then that would mean implementing this change, and then updating citar-shorten-names to account for braces; right?

@aikrahguzar
Copy link
Contributor

aikrahguzar commented Apr 13, 2022

So then that would mean implementing this change, and then updating citar-shorten-names to account for braces; right?

Yes. Only the part of letting citar-shorten-names take braces into account is simple.

@bdarcus
Copy link
Contributor

bdarcus commented Jun 16, 2022

Update on:

joost just updated parsebib to version 4, which includes this enhancement.

joostkremers/parsebib@83a77ea

That solves #535, but am not sure yet how it will impact this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants