Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using the Code Viewer in core Jupyterlab #2711

Open
ajbozarth opened this issue May 5, 2022 · 2 comments · May be fixed by #3265
Open

Switch to using the Code Viewer in core Jupyterlab #2711

ajbozarth opened this issue May 5, 2022 · 2 comments · May be fixed by #3265
Labels
component:code-viewer external:jupyterlab 4.0 kind:enhancement New feature or request sizing: XS
Milestone
4.0.0

Comments

@ajbozarth
Copy link
Member

With the merge of jupyterlab/jupyterlab#12365 the Code Viewer is now a part of core Jupyterlab on master. Once this feature is released, most likely in 4.0, we should switch to using that version and remove/deprecate the @elyra/code-viewer-extension.
@ajbozarth ajbozarth added this to the 4.0.0 milestone May 5, 2022
@ajbozarth
Copy link
Member Author

The code change for this would just be updating the following line:

elyra/packages/pipeline-editor/src/PipelineEditorWidget.tsx

Line 102 in 8d4fd8c

openViewer: 'elyra-code-viewer:open'

to openViewer: 'code-viewer:open'

and then removing the code-viewer package

@ptitzler ptitzler modified the milestones: 4.x Q1, 4.x Q2 Feb 2, 2023
@ptitzler
Copy link
Member

Additional work items:

@lresende lresende linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:code-viewer external:jupyterlab 4.0 kind:enhancement New feature or request sizing: XS
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Switch from elyra-code-viewer to jupyterlab-code-viewer lresende/elyra
2 participants
@ptitzler @ajbozarth