Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images linked in package READMEs are not scaled #238

Open
bobwhitelock opened this issue Jul 1, 2017 · 3 comments
Open

Images linked in package READMEs are not scaled #238

bobwhitelock opened this issue Jul 1, 2017 · 3 comments
Labels

Comments

@bobwhitelock
Copy link

As originally described in rtfeldman/elm-css#283.

While images linked from package READMEs are shown scaled and centred when viewed on Github (e.g. here), on http://package.elm-lang.org they are shown at the original image size. This means that they can overflow the border of the rest of the README and overlap the 'module docs' menu to the right, as can be seen here, or as an image here.

While package authors could attempt to work around this by sizing images appropriately themselves, it seems more the responsibility of package.elm-lang.org to ensure it appropriately sizes images it wants to display; I imagine it would also be difficult to manually size images appropriately for both places without there being any loss of resolution in one case for users with certain monitor resolutions.

@process-bot
Copy link

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@tgecho
Copy link

tgecho commented Jul 3, 2017

Setting a scoped max-width: 100% on any img tags would be a pretty simple first step. This is the result of doing so via dev tools on elm-css:

screen shot 2017-07-02 at 10 48 54 pm

@akoppela
Copy link

akoppela commented Jul 3, 2017

PR for that #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants