Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow displaying warning even on successful builds #141

Closed
mdevlamynck opened this issue Apr 20, 2018 · 5 comments
Closed

Allow displaying warning even on successful builds #141

mdevlamynck opened this issue Apr 20, 2018 · 5 comments

Comments

@mdevlamynck
Copy link

It would be very nice to have the compiler warnings even on successful builds.

Currently the only way to get these warnings is to have a failing build (they are present among the error messages). elm-make will print them even on successful build so I guess the loader is just not forwarding the compiler output (showing only the warning and not all the output would require parsing the output to find the warning section). I don't know much about how webpack works, do you think this is something doable?

I'll try to take a look at the loader's code to see if I can hack something into a PR.

@halfzebra
Copy link
Contributor

Probably this has to be addressed in rtfeldman/node-elm-compiler, there's an issue for that on the repo. You are very welcome to leave feedback there.

@rtfeldman
Copy link
Member

Compiler warnings are being removed in 0.19 and it's not certain they'll be re-added, so it's probably best to hold off. 😄

@halfzebra
Copy link
Contributor

Thanks for the reply, that's a good point!

@halfzebra
Copy link
Contributor

I'm assuming this one can be closed, because of #142 🤔

@halfzebra
Copy link
Contributor

@Skinney thanks for taking over! 🎉 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants