Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ampersand (&) in title or description are displayed as & #266

Closed
FunnyPocketBook opened this issue Apr 6, 2024 · 6 comments · Fixed by #271
Closed

[BUG] Ampersand (&) in title or description are displayed as & #266

FunnyPocketBook opened this issue Apr 6, 2024 · 6 comments · Fixed by #271
Assignees
Labels
bug Something isn't working Can reproduce I can reproduce the bug

Comments

@FunnyPocketBook
Copy link

Wallos version: 1.19.0
Installation: Docker (docker compose)
Host system: Unraid v6.12.6

Expected Behaviour

  • An ampersand & is rendered as &

Actual Behaviour

  • An ampersand & is rendered as &

Steps to reproduce

  1. Create a new subscription or edit any existing one
  2. Add an ampersand (&) to any text field
  3. Save the subscription
  4. The ampersand is now displayed as &

Additional info

Since an ampersand is also present in the &, every time the subscription is saved, a new amp; shows up.

Screenshots

image
image

@ellite ellite self-assigned this Apr 6, 2024
@ellite ellite added bug Something isn't working Can reproduce I can reproduce the bug labels Apr 6, 2024
@ellite
Copy link
Owner

ellite commented Apr 6, 2024

Hi. Thank you for the report. I'll try to fix it.

@DanteB918
Copy link
Contributor

Hi. Thank you for the report. I'll try to fix it.

htmlspecialchars_decode() should do the trick, it just escapes the HTML so & would be & 😄

Hope this helps!

https://www.php.net/manual/en/function.htmlspecialchars-decode.php

@ellite
Copy link
Owner

ellite commented Apr 7, 2024

Thank you. I'll check.

@ellite ellite linked a pull request Apr 9, 2024 that will close this issue
@ellite
Copy link
Owner

ellite commented Apr 9, 2024

Should be fixed with 1.20.1
You need to edit the subscription and replace & with &

Regards.

And thank you @DanteB918 for the suggestion.

@FunnyPocketBook
Copy link
Author

Thanks, that worked! However, the other text fields (e.g. notes or URL) are still showing the same. Could you also call the function for those fields?

@ellite
Copy link
Owner

ellite commented Apr 10, 2024

Ah, of course. Forgot about those.
I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Can reproduce I can reproduce the bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants