Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make images in preview zoomable via pinch zoom #1595

Closed
Shinigami92 opened this issue Feb 3, 2023 · 4 comments · Fixed by #1620
Closed

Make images in preview zoomable via pinch zoom #1595

Shinigami92 opened this issue Feb 3, 2023 · 4 comments · Fixed by #1620
Labels
c: feature Request for new feature c: ui Enhancing UI s: accepted Accepted feature / Confirmed bug

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented Feb 3, 2023

On mobile/pwa it is sometimes hard to read content in an image
It should be possible to zoom the image via pinch zoom
The content in background should not be affected by that

@Shinigami92 Shinigami92 added the s: pending triage Pending Triage label Feb 3, 2023
@stackblitz
Copy link

stackblitz bot commented Feb 3, 2023

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@sarajw
Copy link

sarajw commented Feb 3, 2023

Thanks for writing the issue, I find this a big problem for mobile use!

@BagelHero
Copy link

This was discussed by some users at issue #740 , they perhaps went unseen because the initial issue was slightly different. I agree with LarsFosdal and clarioncat's notes in there, for what that's worth.

@purcell
Copy link

purcell commented Feb 4, 2023

Yes! It's super common to click on an image on mobile devices and then want to zoom and pan around, either to see details or read small text. The inability to do this has really been the only jarring thing I've encountered when using Elk.

@Shinigami92 Shinigami92 added c: feature Request for new feature help wanted Extra attention is needed c: ui Enhancing UI s: accepted Accepted feature / Confirmed bug and removed s: pending triage Pending Triage labels Feb 4, 2023
@Shinigami92 Shinigami92 removed the help wanted Extra attention is needed label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: ui Enhancing UI s: accepted Accepted feature / Confirmed bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants