Model configuration is not loaded from character file

[TbLtzk]

Describe the bug

It is currently not possible to override model configuration parameters via the character file.

To Reproduce

Create a character.json file with the following modelConfig object

    "settings": {
        "secrets": {},
        "modelConfig": {
            "maxInputTokens": 256000,
            "maxOutputTokens": 8196,
            "temperature": 0.2,
            "frequency_penalty": 0.0,
            "presence_penalty": 0.0
        },    
        "voice": {
            "model": "en_US-female-medium"
        }

Expected behavior

The existing code base suggests that an override should be possible: https://github.com/TbLtzk/eliza/blob/bfe4fddffe95ba9f494a8203f7731504c05fe71f/packages/core/src/generation.ts#L373

But the modelConfig object is always undefined, I think because it's not included in the schema.

Additional context

I have a fix for this and could create a pull request: TbLtzk@6216ff9

I renamed max_response_length to maxOutputTokens to be consistent with the modelSettings. Further, I don't think that modelConfig is the ideal name for the object, but this is induced by the existing code base (see permalink above). I did not change that, for now.

[github-actions]

Hello @TbLtzk! Welcome to the elizaOS community. Thank you for opening your first issue; we appreciate your contribution. You are now an elizaOS contributor!

[TbLtzk]

There's still a bug in my fix, because I did not rename the max_response_length in types.ts. I'll provide an updated commit...

UPDATE: fixed TbLtzk@6216ff9

[tcm390]

Hi @TbLtzk, would you mind opening a PR for your fix? That would be really helpful. Thanks! 😊