Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: change code action for "underscoring" a variable to "rename to _var_name" #494

Open
megalithic opened this issue May 21, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@megalithic
Copy link

megalithic commented May 21, 2024

Presently running lexical and next-ls side-by-side for a couple things and noticed lexical's code action for adding an underscore to a variable has a helpful detail, in that it explicitly calls out what it's doing and to which variable in the function head..

image

Could be a good first issue, since the pieces seem to all be there; that is, IF this is something the elixir-tools team might want/see valuable.

https://github.com/elixir-tools/next-ls/blob/main/lib/next_ls/extensions/elixir_extension/code_action/unused_variable.ex

@megalithic megalithic changed the title Suggestion: change code action for "underscoring" a parameter to "rename to _var_name" Suggestion: change code action for "underscoring" a parameter to "rename to _param_name" May 21, 2024
@megalithic megalithic changed the title Suggestion: change code action for "underscoring" a parameter to "rename to _param_name" Suggestion: change code action for "underscoring" a variable to "rename to _var_name" May 21, 2024
@mhanberg
Copy link
Collaborator

seems like a fine change

@mhanberg mhanberg added the good first issue Good for newcomers label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants