feat: defmodule snippet infer module name #398
Conversation
lucacervello
force-pushed
the
defmodule-snippet-infer-module-name
branch
from
f97809b
to
dc54829
Compare
| result = | ||
| uri | ||
| |> Path.split() | ||
| |> Enum.reduce(false, fn |
There was a problem hiding this comment.
Can you explain what the first element of the accumulator signifies here?
The clause with support is confusing me a tad.
There was a problem hiding this comment.
Usually the module in test/support don't use Test in the module name like https://github.com/elixir-tools/next-ls/blob/main/test/support/utils.ex
Can you explain what the first element of the accumulator signifies here?
do you mean false?
There was a problem hiding this comment.
I meant the tuple {:test, []}. I'm not sure what the atom is doing
There was a problem hiding this comment.
It's used here to check if there is support under test
There was a problem hiding this comment.
That is the line that I am asking about.
I'm not sure where you use that later, you said something about tests ending in "Test", but i'm not seeing that either in this code
There was a problem hiding this comment.
Oh my bad, I'll try to explain.
I'm looking for three folders
libwhere usually the code is,lib/foo.exit's translated toFoo(withoutlib)testwhere usually the tests are,test/foo_test.exsit's translated toFooTest(withouttest)supportwhere usually are utils for tests,test/support/foo.exit's translated toFoo(withouttestandsupport)
here are some tests that can help https://github.com/elixir-tools/next-ls/blob/9d65b759ac0cf86c943190342cf829097fc62346/test/next_ls/snippet_test.exs
There was a problem hiding this comment.
oh, i understand now, thanks!
basically you are just striping lib/, test/ and test/support/ from the beginning for the path.
There was a problem hiding this comment.
@lucacervello When you use someone else's code, please mention the source. If possible, contacting the author would be best; otherwise, it appears quite unethical.
There was a problem hiding this comment.
I've removed the code on main.
Sorry about that!
|
You're on fire! |
| def ascend(nil, acc, _callback), do: acc | ||
|
|
There was a problem hiding this comment.
is this change necessary?
There was a problem hiding this comment.
Yes
without it
defmod|don't trigger autocomplete because there is no previous node
mhanberg
force-pushed
the
defmodule-snippet-infer-module-name
branch
from
9d65b75
to
0c48c40
Compare
defmodule snippet infer module name
recording 🎥
Screen.Recording.2024-03-14.at.09.29.30.mov