Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snippets #385

Merged
merged 4 commits into from
Mar 8, 2024
Merged

feat: add snippets #385

merged 4 commits into from
Mar 8, 2024

Conversation

lucacervello
Copy link
Contributor

Closes #59

lib/next_ls.ex Outdated Show resolved Hide resolved
@lucacervello lucacervello force-pushed the add-snippets branch 2 times, most recently from 8d4449f to 8fbe1c2 Compare March 5, 2024 12:53
@mhanberg
Copy link
Collaborator

mhanberg commented Mar 5, 2024

Another thing is you need to preserve the documentation in the completion item in the snippet

@lucacervello
Copy link
Contributor Author

lucacervello commented Mar 5, 2024

Should I add a new parameter to the Snippet.get/2 function or use the second one as docs?
Or we don't want Snippet.get/2 to change?

@mhanberg
Copy link
Collaborator

mhanberg commented Mar 5, 2024

Doing a Map.merge(original,snippet) might do the trick, no need to change the snippet function

@mhanberg
Copy link
Collaborator

mhanberg commented Mar 5, 2024

I'll try and play with this soon, currently wrapping up some work on the editor extensions.

@mhanberg
Copy link
Collaborator

mhanberg commented Mar 8, 2024

made a couple changes, otherwise great!

@mhanberg mhanberg enabled auto-merge (squash) March 8, 2024 04:03
@mhanberg mhanberg merged commit 92248b6 into elixir-tools:main Mar 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snippets
2 participants