Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autocomplete for kernel functions #373

Merged

Conversation

lucacervello
Copy link
Contributor

Add autocomplete for Kernel functions like put_in/2, ++/2, defstruct/1

@mhanberg
Copy link
Collaborator

So I originally didn't include Kernel functions because, unlike SpecialForms, you can't remove them from scope with import.

So here technically you could un-import def and make your own def and the autocomplete would show you the wrong documentation, or show it to you even tho you un-imported it (in the case you don't define your own.

That being said, it since completions are still experimental, it might be already to include Kernel functions, as for most people they probably aren't messing with them outside of library code.

@mhanberg mhanberg force-pushed the autocomplete-kernel-functions branch from 94d23a8 to 9c3c4f5 Compare February 21, 2024 23:34
@mhanberg
Copy link
Collaborator

alright i played with this for 8 seconds and its worth adding

@mhanberg mhanberg enabled auto-merge (squash) February 21, 2024 23:35
@mhanberg mhanberg merged commit ff1b89d into elixir-tools:main Feb 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants