fix: handle when auto updater receives a non-200 from GitHub API #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhanberg
reviewed
Dec 22, 2023
lib/next_ls/updater.ex
Outdated
| @@ -65,6 +65,12 @@ defmodule NextLS.Updater do | |||
| end | |||
| end | |||
|
|
|||
| {:ok, %{status: 403, body: %{"message" => msg}} = _body} -> | |||
There was a problem hiding this comment.
Instead of adding these two specific checks, let's make the existing check less specific (don't pattern match on the error atom).
Keep the status 200 in the first check tho
There was a problem hiding this comment.
Sure, no problem. By "error atom" do you mean the status field, or the "message" field? (I wasn't sure if Github returns a message for non-403 responses.)
There was a problem hiding this comment.
No, I mean the atom on line 74
mhanberg
changed the title
mhanberg
changed the title
|
thanks! |
This was referenced Jan 18, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal fix to the crash reported in #350 - e.g. Github API returns a 403 or other non-200 error. (Github's API docs do not make it easy to find the response schema for errors, only successes, unfortunately.)
Fixes #350