Support passing target and env options from LSP
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, I think the second part would be adding that can be done later tho. I'll make some updates to this this weekend if you're cool with it and then i'll update the editor plugins. thanks for the patch! |
mhanberg
reviewed
Sep 30, 2023
jjcarstens
force-pushed
the
support-target-env
branch
2 times, most recently
from
c11373e
to
2281516
Compare
mhanberg
force-pushed
the
support-target-env
branch
from
2281516
to
8f8f276
Compare
This was referenced Oct 2, 2023
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #245