From fd2f638b39617f594b996b2b4085ed3e7206f1e4 Mon Sep 17 00:00:00 2001 From: Mitchell Hanberg Date: Tue, 20 Jun 2023 11:43:53 -0700 Subject: [PATCH] fix(elixir): format inside runtime This ensures that formatter plugins can be utilized. --- lib/next_ls.ex | 8 +++++--- test/next_ls_test.exs | 17 +++++++++-------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/lib/next_ls.ex b/lib/next_ls.ex index 74197430..52115e5f 100644 --- a/lib/next_ls.ex +++ b/lib/next_ls.ex @@ -97,9 +97,11 @@ defmodule NextLS do def handle_request(%TextDocumentFormatting{params: %{text_document: %{uri: uri}}}, lsp) do document = lsp.assigns.documents[uri] - working_dir = URI.parse(lsp.assigns.root_uri).path - {opts, _} = Code.eval_file(".formatter.exs", working_dir) - new_document = Code.format_string!(Enum.join(document, "\n"), opts) |> IO.iodata_to_binary() + {formatter, _} = Runtime.call(lsp.assigns.runtime, {Mix.Tasks.Format, :formatter_for_file, [".formatter.exs"]}) + + new_document = + Runtime.call(lsp.assigns.runtime, {Kernel, :apply, [formatter, [Enum.join(document, "\n")]]}) + |> IO.iodata_to_binary() {:reply, [ diff --git a/test/next_ls_test.exs b/test/next_ls_test.exs index 548bd149..db6f9c43 100644 --- a/test/next_ls_test.exs +++ b/test/next_ls_test.exs @@ -190,6 +190,9 @@ defmodule NextLSTest do params: %{} }) + assert_notification "window/logMessage", + %{"message" => "[NextLS] Runtime ready..."} + notify client, %{ method: "textDocument/didOpen", jsonrpc: "2.0", @@ -226,15 +229,13 @@ defmodule NextLSTest do } } - new_text = - """ - defmodule Foo.Bar do - def run() do - :ok - end + new_text = """ + defmodule Foo.Bar do + def run() do + :ok end - """ - |> String.trim() + end + """ assert_result( 2,