Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextls): allow extension to force a download #81

Merged
merged 8 commits into from
Mar 6, 2024

Conversation

mhanberg
Copy link
Contributor

@mhanberg mhanberg commented Mar 4, 2024

In the case that the auto updater in Next LS has a bug, this
patch allows the extension to force a fresh download through the
extension.

It sets a key in the extensions globalState, which is persisted across
restarts. If the key isn't there, then it forces the download.

To force a download a second time, you need to increment the key
version, which is basically setting a new key to use as a sentinel.

Copy link
Contributor Author

mhanberg commented Mar 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mhanberg and the rest of your teammates on Graphite Graphite

Base automatically changed from 2024-03-02-pipe to main March 4, 2024 18:50
In the case that the auto updater in Next LS has a bug, this
patch allows the extension to force a fresh download through the
extension.

It sets a key in the extensions globalState, which is persisted across
restarts. If the key isn't there, then it forces the download.

To force a download a second time, you need to increment the key
version, which is basically setting a new key to use as a sentinel.
@mhanberg mhanberg merged commit 80d84c2 into main Mar 6, 2024
6 checks passed
@mhanberg mhanberg deleted the 2024-03-04-force_download branch March 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant