Rename downcase_request_headers to case_sensitive_headers

Author: DunyaKokoschka

lib/mint/http1.ex

@@ -94,7 +94,7 @@ defmodule Mint.HTTP1 do
     :transport,
     :mode,
     :scheme_as_string,
-    :downcase_request_headers,
+    :case_sensitive_headers,
     requests: :queue.new(),
     state: :closed,
     buffer: "",
@@ -119,6 +119,13 @@ defmodule Mint.HTTP1 do
   Same as `Mint.HTTP.connect/4`, but forces an HTTP/1 or HTTP/1.1 connection.
 
   This function doesn't support proxying.
+
+  ## Additional Options
+
+    * `:case_sensitive_headers` - (boolean) if set to true the case of the supplied
+       headers in requests will be preserved. The default is to lowercase the headers
+       because http/1.1 header names are not case-insensitive.
+
   """
   @spec connect(Types.scheme(), Types.address(), :inet.port_number(), keyword()) ::
           {:ok, t()} | {:error, Types.error()}
@@ -195,7 +202,7 @@ defmodule Mint.HTTP1 do
         scheme_as_string: Atom.to_string(scheme),
         state: :open,
         log: log?,
-        downcase_request_headers: Keyword.get(opts, :downcase_request_headers, true)
+        case_sensitive_headers: Keyword.get(opts, :case_sensitive_headers, false)
       }
 
       {:ok, conn}
@@ -273,7 +280,7 @@ defmodule Mint.HTTP1 do
            Request.encode(
              method,
              path,
-             Headers.to_raw_headers(headers, conn.downcase_request_headers),
+             Headers.to_raw_headers(headers, conn.case_sensitive_headers),
              body
            ),
          :ok <- transport.send(socket, iodata) do

lib/mint/http1/headers.ex

@@ -11,13 +11,13 @@ defmodule Mint.HTTP1.Headers do
   end
 
   @spec to_raw_headers([header()], boolean()) :: [raw_header()]
-  def to_raw_headers(headers, downcase_headers) do
-    if downcase_headers do
+  def to_raw_headers(headers, case_sensitive_headers) do
+    if case_sensitive_headers do
+      Enum.map(headers, fn {name, _canonical_name, value} -> {name, value} end)
+    else
       Enum.map(headers, fn {_name, canonical_name, value} ->
         {canonical_name, value}
       end)
-    else
-      Enum.map(headers, fn {name, _canonical_name, value} -> {name, value} end)
     end
   end
 

test/mint/http1/conn_test.exs

@@ -652,8 +652,7 @@ defmodule Mint.HTTP1Test do
     end
 
     test "non lower case headers", %{port: port, server_ref: server_ref} do
-      assert {:ok, conn} =
-               HTTP1.connect(:http, "localhost", port, downcase_request_headers: false)
+      assert {:ok, conn} = HTTP1.connect(:http, "localhost", port, case_sensitive_headers: true)
 
       assert_receive {^server_ref, server_socket}
       body = "body"
@@ -684,8 +683,7 @@ defmodule Mint.HTTP1Test do
     end
 
     test "non lower case headers using defaults", %{port: port, server_ref: server_ref} do
-      assert {:ok, conn} =
-               HTTP1.connect(:http, "localhost", port, downcase_request_headers: false)
+      assert {:ok, conn} = HTTP1.connect(:http, "localhost", port, case_sensitive_headers: true)
 
       assert_receive {^server_ref, server_socket}
       body = "body"
@@ -716,8 +714,7 @@ defmodule Mint.HTTP1Test do
       port: port,
       server_ref: server_ref
     } do
-      assert {:ok, conn} =
-               HTTP1.connect(:http, "localhost", port, downcase_request_headers: false)
+      assert {:ok, conn} = HTTP1.connect(:http, "localhost", port, case_sensitive_headers: true)
 
       assert_receive {^server_ref, server_socket}
 
@@ -741,8 +738,7 @@ defmodule Mint.HTTP1Test do
     end
 
     test "non lower case headers gzip encoding", %{port: port, server_ref: server_ref} do
-      assert {:ok, conn} =
-               HTTP1.connect(:http, "localhost", port, downcase_request_headers: false)
+      assert {:ok, conn} = HTTP1.connect(:http, "localhost", port, case_sensitive_headers: true)
 
       assert_receive {^server_ref, server_socket}