Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand & shrink selection don't follow Elixir syntax #192

Closed
crispinb opened this issue Jun 3, 2021 · 1 comment
Closed

Expand & shrink selection don't follow Elixir syntax #192

crispinb opened this issue Jun 3, 2021 · 1 comment

Comments

@crispinb
Copy link

crispinb commented Jun 3, 2021

ie. the actions editor.action.smartSelect.expand & editor.action.smartSelect.shrink don't work as expected.

For example a selection will expand from a single word in a function to a whole line in one step (regardless of content), and to the whole module in the next.

Is this the right repo?

I think so. The VSCode Output window, with Elixir-ls logging switched on, shows no output when I attempt expand/shrink selection, which I take to indicate that the extension handles this internally?

Environment

  • Elixir & Erlang versions (elixir --version): 1.12.0 / 24.0
  • VSCode ElixirLS version: 0.7.0
  • Operating System Version: Windows 10 21H1 (but Elixir & vs code extension running on Ubuntu 20.04 in wsl)
@crispinb
Copy link
Author

crispinb commented Jun 3, 2021

Apologies, since posting this I've found elixir-lsp/elixir-ls#534 and https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_selectionRange. So I'll close this here.

@crispinb crispinb closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant