Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support folding range source code #108

Closed
wingyplus opened this issue Aug 26, 2020 · 3 comments
Closed

Feature Request: Support folding range source code #108

wingyplus opened this issue Aug 26, 2020 · 3 comments

Comments

@wingyplus
Copy link

The original issue come from elixir-lsp/elixir-ls#358, start from support do/end block would be good. Love to hear your feedback.

NOTE: I have a prototype version on ElixirLS that use :elixir_tokenizer here wingyplus/elixir-ls@2d9a94c.

@axelson
Copy link
Member

axelson commented Sep 19, 2020

Code folding would be great to have! Although for the implementation it would be best to not rely on :elixir_tokenizer because it is a private elixir implementation detail and may change significantly between elixir versions (which would cause elixir_sense to break).

@wingyplus
Copy link
Author

Code folding would be great to have! Although for the implementation it would be best to not rely on :elixir_tokenizer because it is a private elixir implementation detail and may change significantly between elixir versions (which would cause elixir_sense to break).

@axelson I have recommended that uses ElixirSense.Core.Normalized.Tokenizer is better than using :elixir_tokenizer directly (refer to this comment elixir-lsp/elixir-ls#358 (comment)). Love to see another way to do it. :)

@lukaszsamson
Copy link
Collaborator

Closing in favour of elixir-lsp/elixir-ls#492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants