Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~H sigils no longer formatted after updating to Elixir 1.15.5 #975

Closed
balexand opened this issue Aug 30, 2023 · 6 comments
Closed

~H sigils no longer formatted after updating to Elixir 1.15.5 #975

balexand opened this issue Aug 30, 2023 · 6 comments
Labels

Comments

@balexand
Copy link

Environment

  • Elixir & Erlang versions (elixir --version): Elixir 1.15.5, OTP 26.0.2
  • Elixir Language Server version: 0.16.0
  • Operating system: Mac OS (Intel, latest)
  • Editor or IDE name (e.g. Emacs/VSCode): VSCode
  • Editor Plugin/LSP Client name and version: jakebecker.elixir-ls 0.16.0

Current behavior

After updating to Elixir 1.15.5 ~H sigils are no longer formatted by the VSCode ElixirLS plugin. To reproduce, generate a new Phoenix project with mix phx.new example. The generated ExampleWeb.CoreComponents module contains ~H sigils that can be used for testing and the generated .formatter.exs file includes plugins: [Phoenix.LiveView.HTMLFormatter]. Running mix format from the command line will result in the ~H sigils being formatted. But if the formatter is run by ElixirLS then the Elixir code is formatted but not the ~H sigils.

Downgrading to Elixir 1.15.4 fixes the problem.

Expected behavior

I would expect ~H sigils to be formatted by ElixirLS as it was prior to Elixir version 1.15.5.

Thanks.

@lukaszsamson
Copy link
Collaborator

Thanks for the report. There were formatter plugin related changes in 1.15.5. I will investigate

@champeric
Copy link

I just want to chime in that I have the exact same problem with the same environment.

@stevencorona
Copy link

I've had the same issue but specifically within an umbrella project - @lukaszsamson @champeric are you both working in umbrella projects as well?

It also seems to work sporatically, almost like it's using the wrong .formatter.exs configuration for the wrong project app.

@lukaszsamson
Copy link
Collaborator

Thanks for reporting. This is a regression in elixir 1.15.5

@lukaszsamson
Copy link
Collaborator

Already fixed upstream and backported to 1.15 branch. 1.16 and 1.15.6 releases should not be affected by this bug

@balexand
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants