-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the executable launchers be named as elixir-ls
#522
Comments
Yes, I got hit by this one as well, using Emacs. Just symlinking |
Luckily for us emacsers, it appears that lsp-mode has reverted that change. Nevertheless, I did find the setup of the language server to be a bit odd since you have to add a new directory to your Thinking about it further, the |
I do agree that |
Hey all! I did some research into mix archives and escritps and here are my conclusions:
With all of that taken into consideration, I did an experiment and got the language server working locally as an escript. The downside to this approach is that I can't find any documentation for multiple escripts from a single (here, umbrella) project. For instance, using the GitHub syntax for this repo would be
but the @axelson I saw that you mentioned in #115 that ElixirLS used to be distributed as an escript, but that was changed over some conflict with ASDF. Do we have any further details around that? ASDF and escripts seem to work together pretty well at the moment. |
The solution needs to cover windows as well so asdf is a no go. |
@lukaszsamson asdf isn't a packaging tool or distribution mechanism by itself, I only wanted to say that asdf works well with escripts, which is a packaging tool, format, and distribution system that I think might work well for ElixirLS. I should have mentioned, though, that escript distribution without asdf means that the user must add |
Don't they have to do the same for current |
@hjpotter92 Yep, assuming they're not using the VS Code plugin which handles such things. The rest of us (emacsers, vimmers, etc) have to modify our |
Is there a consensus how the launchers should be called? |
It is more of a feature request, but the launch script for the language server is named as
language_server.bat
for windows andlanguage_server.sh
for unix, however the readme has just 1 mention of the termlanguage_server
(only for the local development section).This created a confusion, as I installed the project on my arch linux through the AUR package, which generates a linked script
/usr/bin/elixir-ls
which is what I had expected.However, when developing within emacs, since
elixir-ls
was not the default name for the server command, it led to issues..The name seems intuitive to me, and if the project release also contains for eg. a symlink named as
elixir-ls.bat
andelixir-ls.sh
, it'd really help new developers just setting up lsp integrations.Cheers
The text was updated successfully, but these errors were encountered: