"Go to Definition" does not work with umbrella apps

[Nezteb]

Environment

• Elixir & Erlang versions (elixir --version):
  • Erlang/OTP 22.3.4.12
  • Elixir 1.8.1
• Operating system:
  • OS X 10.15.7
• Editor or IDE name (e.g. Emacs/VSCode):
  • VS Code
• Editor Plugin/LSP Client name:
  • https://github.com/elixir-lsp/vscode-elixir-ls

In this example, I'm trying to "Go to Definition" on Phoenix's render function, which is being used within an umbrella app:

I'd expect it to bring me to the deps/phoenix folder like so:

In 2017, @JakeBecker said that umbrella apps are not supported: JakeBecker/vscode-elixir-ls#6 (comment)

I've searched this repo as well as the VS Code extension repo, and umbrella app support doesn't seem to be listed anywhere on any roadmap. The lack of support for umbrella apps also isn't listed in either project's README. There are some old issues for both projects that loosely touch on this subject, but they never explicitly call out the lack of "Go to Definition" support, so I figured I'd create this one until someone can decide what the best thing to do is.

[axelson]

Hi 👋!, thanks for the report! Umbrella applications are expected to be fully supported. It looks like you are running into #193 since that render function is actually a phoenix function imported by the use statement: https://hexdocs.pm/phoenix/Phoenix.Controller.html?#render/3

I'm going to close this for now, but if you find other issues specific to umbrellas, then please file a new issue.