Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Ecto.SQLRepo #637

Open
josevalim opened this issue Oct 7, 2024 · 0 comments
Open

Introduce Ecto.SQLRepo #637

josevalim opened this issue Oct 7, 2024 · 0 comments
Labels

Comments

@josevalim
Copy link
Member

Elixir version

All

Database and Version

All

Ecto Versions

All

Database Adapter and Versions (postgrex, myxql, etc)

All

Current behavior

Today, we define several functions in Ecto.Adapters.SQL and we generate functions with docs inside the Ecto.Repo. This is a contrast to how Ecto.Repo works, which defines several callbacks in Ecto.Repo and lets the documentation tool tie them together.

Expected behavior

My suggestion is to introduce Ecto.SQLRepo which defines all relevant callbacks for the functions we generate, making them more consistent. The Ecto.Adapters.SQL API can then focus on custom adapter implementations.

There is no rush to implement this. I am documenting this for posteriority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant