Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API hosted at off-spec location #48

Closed
uniqueg opened this issue Feb 10, 2023 · 3 comments
Closed

API hosted at off-spec location #48

uniqueg opened this issue Feb 10, 2023 · 3 comments
Assignees
@lvarin

Comments

@uniqueg
Copy link
Member

uniqueg commented Feb 10, 2023

TESK instances are currently hosted at https://host/v1, but according to TES v1.0 and v1.1 they should be hosted at https://host/ga4gh/tes/v1 instead.

Surely this can be configured in Kubernetes by re-routing, but it may also be hardcoded in this repo. If so, it might be good to change it in accordance with the specs. Either way, the deployment instructions should be double-checked and modified if needed.
@uniqueg uniqueg mentioned this issue Feb 10, 2023
Open
@lvarin
Copy link
Contributor

lvarin commented Feb 10, 2023

I will take a look

@lvarin lvarin self-assigned this Feb 10, 2023
@lvarin
Copy link
Contributor

lvarin commented Feb 13, 2023 •
edited
Loading

As far as I can see tesk-api already exposes its API by default in /g4agh/v1/. Like in:
https://csc-tesk-noauth.rahtiapp.fi/swagger-ui.html#/TaskService

The HELM chart has a different default /v1. I will create a small PR to TESK to fix this.

@uniqueg
Copy link
Member Author

uniqueg commented Feb 13, 2023

Perfect, thanks a lot.

Merged the PR, so closing this

@uniqueg uniqueg closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvarin lvarin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lvarin @uniqueg