Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write models for custom config validation #164

Open
uniqueg opened this issue Nov 1, 2023 · 0 comments
Open

Write models for custom config validation #164

uniqueg opened this issue Nov 1, 2023 · 0 comments
Labels
flag: good 1st issue Good for newcomers priority: medium Medium priority type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve

Comments

@uniqueg
Copy link
Member

uniqueg commented Nov 1, 2023

Is your feature request related to a problem? Please describe.

Since v0.9.0, FOCA supports the validation of custom config params when provided with a Pydantic model class: https://github.com/elixir-cloud-aai/foca#custom-configuration

Describe the solution you'd like

Implement the models in file pro_wes/config_models.py and pass to Foca() constructor in pro_wes/app.py.

Additional context

This functionality is currently already implemented in proWES, so that could be used as an example/template:

@uniqueg uniqueg added flag: good 1st issue Good for newcomers priority: medium Medium priority type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: good 1st issue Good for newcomers priority: medium Medium priority type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve
Projects
None yet
Development

No branches or pull requests

1 participant