Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination support for "GET /objects" #59

Open
uniqueg opened this issue Jun 20, 2024 · 2 comments
Open

feat: add pagination support for "GET /objects" #59

uniqueg opened this issue Jun 20, 2024 · 2 comments

Comments

@uniqueg
Copy link
Member

uniqueg commented Jun 20, 2024

Follow the new GA4GH pagination guide (draft) to implement a means of paginating the response: https://docs.google.com/document/d/1pu2icPEll-vueFcjCuUnjuAwEvtahOf_dyyaP5qqbCs/edit

@heisdinesh
Copy link

Hi @uniqueg, I have a question. Should pagination be implemented only at the API level for the Get Objects endpoint, or should we implement it in the FOCA project and use it from there?

Also, I cannot access the Slack channel (For signup, it is asking my email to be associated with @ebi.ac.uk domain.) Could you guide me like where to discuss the features and issues.

Thank you.

@uniqueg
Copy link
Member Author

uniqueg commented Mar 5, 2025

Thanks @heisdinesh. Good question - at the moment we are implementing pagination separately in each service - but I see that it would make more sense doing it as a util in FOCA. However, FOCA is currently under heavy rebuild due to the migration to Connexion v3, which comes with a lot of breaking changes. So the best way forward here is probably to implement it here cleanly, using proper isolation, so that it can be easily migrated to FOCA once we are ready.

As for discussions: These indeed happen on Slack. I'm not exactly sure what your issue is - where exactly is it asking you about the domain? Please try again with this invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants