Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pr_evaluation wokrflow has conflict #18

Open
JaeAeich opened this issue Oct 10, 2024 · 1 comment · May be fixed by #19
Open

fix: pr_evaluation wokrflow has conflict #18

JaeAeich opened this issue Oct 10, 2024 · 1 comment · May be fixed by #19
Labels
flag: good 1st issue Good for newcomers priority: high High priority

Comments

@JaeAeich
Copy link
Collaborator

The pr_evaluation workflow doesn't work.

Error:

The workflow is not valid. .github/workflows/pr_validation.yaml (Line: 13, Col: 12): Job 'detect-unresolved-conflicts' depends on unknown job 'semantic_pr'.

Change the dependency of the workflow, can be fixed by moving them in topological order. Also set specific event for each workflow, current they all run whenever the PR is edited, repopend etc etc, but semantic PR check should only be run again if the PR title is edited, similarly map other checks to their conditions as well, this will allow us to stop not run workflow uselessly.

@JaeAeich JaeAeich added flag: good 1st issue Good for newcomers priority: high High priority labels Oct 10, 2024
@uniqueg
Copy link
Member

uniqueg commented Oct 11, 2024

Thanks for reporting. But when you prepare a fix, please only focus on the fix - don't include the other stuff you mention on workflow triggering, that's a separate issue (possibly more).

@JaeAeich JaeAeich linked a pull request Oct 14, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: good 1st issue Good for newcomers priority: high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants