Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughIntroduces a new client-side WelcomeUpgradeHeader component, refactors welcome-upgrade/page.tsx to use it, adds a typed pricing-copy feature-flag hook (usePricingCopyVariant), and bumps version to v2.6.3. Header content now varies by feature-flag variant and pulls userCount from config. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant P as welcome-upgrade/page.tsx
participant PL as PricingLazy
participant H as WelcomeUpgradeHeader
participant FF as usePricingCopyVariant
participant SDK as useFeatureFlagVariantKey
U->>P: Visit /welcome-upgrade
P->>PL: Render <PricingLazy header={<WelcomeUpgradeHeader />} />
PL->>H: Render header
H->>FF: Call usePricingCopyVariant()
FF->>SDK: get("pricing-copy")
SDK-->>FF: variant key or undefined
FF-->>H: "control" | "free-trial-emphasis" (default: control)
H-->>PL: Render heading + trial features (uses userCount)
PL-->>U: Page displayed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
apps/web/hooks/useFeatureFlags.ts (1)
65-68: Use a named constant for the flag key (match the HERO pattern).Minor consistency/readability: mirror
HERO_FLAG_NAMEby extracting"pricing-copy"to a constant and reference it here to avoid typos.Apply within this hunk:
- (useFeatureFlagVariantKey("pricing-copy") as PricingCopyVariant) || + (useFeatureFlagVariantKey(PRICING_COPY_FLAG_NAME) as PricingCopyVariant) ||And add near the other flag name constants (outside this hunk):
export const PRICING_COPY_FLAG_NAME = "pricing-copy";apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsx (5)
19-22: Avoid hardcoding trial length; read from config.If the trial duration changes, this copy will drift. Source it from config/env to keep copy accurate.
Apply in this hunk:
- Start your 7-day FREE trial + Start your {trialDays}-day FREE trialAdd in config (outside this file), e.g.
apps/web/utils/config.ts:export const trialDays = 7 as const;And import at the top of this file:
import { userCount, trialDays } from "@/utils/config";
13-16: Heading order nit: prefer H1 as the primary heading, eyebrow as a paragraph.For semantic hierarchy and screen-readers, consider rendering the eyebrow as a paragraph instead of an H2.
- <h2 className="font-cal text-base leading-7 text-blue-600"> + <p className="font-cal text-base leading-7 text-blue-600"> Spend 50% less time on email - </h2> + </p>
45-46: A11y for SVG icon: add a title or mark decorative.Our guidelines call for a title on SVGs. Since this icon is decorative (text follows), either:
- Add a descriptive title (strict guideline compliance), or
- Mark it decorative with
aria-hidden(common a11y practice).Pick one approach and standardize across icons.
Option A (title):
- <CheckCircleIcon className="mr-2 h-4 w-4 text-green-500" /> + <CheckCircleIcon title="Checkmark" className="mr-2 h-4 w-4 text-green-500" />Option B (decorative):
- <CheckCircleIcon className="mr-2 h-4 w-4 text-green-500" /> + <CheckCircleIcon aria-hidden="true" focusable="false" className="mr-2 h-4 w-4 text-green-500" />
43-48: Prefer importing the ReactNode type over using the React namespace.Keeps types tree-shakeable and avoids relying on the global
Reactnamespace.Apply in this hunk:
-const TrialFeature = ({ children }: { children: React.ReactNode }) => ( +const TrialFeature = ({ children }: { children: ReactNode }) => (Add at the top of the file (outside this hunk):
import type { ReactNode } from "react";
34-38: Optional: define features as data and map to UI.Slight DRY win and easier future edits/i18n.
Example:
const trialFeatures = [ "100% no-risk trial", "Free for the first 7 days", "Cancel anytime, hassle-free", ] as const; // ... <div className="mx-auto mt-4 flex flex-col items-start gap-2"> {trialFeatures.map((text) => ( <TrialFeature key={text}>{text}</TrialFeature> ))} </div>
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsx(1 hunks)apps/web/app/(landing)/welcome-upgrade/page.tsx(1 hunks)apps/web/hooks/useFeatureFlags.ts(1 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (17)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
version.txtapps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/hooks/useFeatureFlags.tsapps/web/app/(landing)/welcome-upgrade/page.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
version.txtapps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/hooks/useFeatureFlags.tsapps/web/app/(landing)/welcome-upgrade/page.tsx
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/hooks/useFeatureFlags.tsapps/web/app/(landing)/welcome-upgrade/page.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/app/(landing)/welcome-upgrade/page.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/hooks/useFeatureFlags.tsapps/web/app/(landing)/welcome-upgrade/page.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/hooks/useFeatureFlags.tsapps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/**/*.ts
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use SWR for efficient data fetching and caching
apps/web/hooks/**/*.ts: Use SWR for client-side data fetching and caching.
Callmutate()after successful mutations to refresh SWR data on the client.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Call
mutate()after successful mutations to refresh dataFiles:
apps/web/hooks/useFeatureFlags.ts**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/hooks.mdc)
Place custom hooks in the
apps/web/hooks/directory.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/use*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/hooks.mdc)
apps/web/hooks/use*.{js,jsx,ts,tsx}: Name custom hooks with theuseprefix (e.g.,useAccounts.ts).
For fetching data from API endpoints in custom hooks, prefer usinguseSWR.
Create dedicated hooks for specific data types (e.g.,useAccounts,useLabels).
Custom hooks should encapsulate reusable stateful logic, especially for data fetching or complex UI interactions.
Keep custom hooks focused on a single responsibility.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/useFeatureFlags.ts
📄 CodeRabbit inference engine (.cursor/rules/posthog-feature-flags.mdc)
apps/web/hooks/useFeatureFlags.ts: All feature flag hooks should be defined in apps/web/hooks/useFeatureFlags.ts
Use kebab-case for feature flag keys (e.g., 'inbox-cleaner', 'pricing-options-2')
Use 'use[FeatureName]Enabled' for boolean flag hook names and 'use[FeatureName]Variant' for variant flag hook names
Always define types for variant flags
Always provide a default/control fallback for variant flags
Keep all feature flag hooks centralized in useFeatureFlags.tsFiles:
apps/web/hooks/useFeatureFlags.ts🧠 Learnings (6)
📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Use 'use[FeatureName]Enabled' for boolean flag hook names and 'use[FeatureName]Variant' for variant flag hook namesApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Always define types for variant flagsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Keep all feature flag hooks centralized in useFeatureFlags.tsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : All feature flag hooks should be defined in apps/web/hooks/useFeatureFlags.tsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Always provide a default/control fallback for variant flagsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Use kebab-case for feature flag keys (e.g., 'inbox-cleaner', 'pricing-options-2')Applied to files:
apps/web/hooks/useFeatureFlags.ts🧬 Code graph analysis (2)
apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsx (2)
apps/web/hooks/useFeatureFlags.ts (1)
usePricingCopyVariant(65-70)apps/web/utils/config.ts (1)
userCount(7-7)apps/web/app/(landing)/welcome-upgrade/page.tsx (2)
apps/web/app/(app)/premium/PricingLazy.tsx (1)
PricingLazy(8-12)apps/web/app/(landing)/welcome-upgrade/WelcomeUpgradeHeader.tsx (1)
WelcomeUpgradeHeader(7-41)🔇 Additional comments (4)
version.txt (1)
1-1: Version bump looks good.v2.6.3 aligns with the PR scope (copy-only changes). No concerns.
apps/web/hooks/useFeatureFlags.ts (1)
63-70: Typed variant with default fallback is correct and consistent.The hook name, kebab-case flag key, union type, and "control" fallback all follow our feature-flag conventions.
apps/web/app/(landing)/welcome-upgrade/page.tsx (2)
10-10: Nice refactor: header moved to a dedicated component.This reduces inline markup and keeps the page lean. Passing
<WelcomeUpgradeHeader />intoPricingLazykeeps the composition flexible.
10-10: PricingPropsheaderprop is correctly typedThe
PricingPropsinterface inapps/web/app/(app)/premium/Pricing.tsxalready definesheader?: React.ReactNode;so passing a
<WelcomeUpgradeHeader />client component will not trigger any RSC boundary warnings.
1 participant
Summary by CodeRabbit