New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove network dependency for Sitemap detection #1

Open

leonstafford opened this issue Mar 4, 2021 · 0 comments

Contributor

leonstafford commented Mar 4, 2021

currently, in https://github.com/leonstafford/WordPressURLDetector/blob/main/src/DetectSitemaps.php, I'm making Guzzle requests to sitemap and robots.txt URLs. This makes things harder to test and the library more brittle.

Removing any network requests will ease usage, remove need to provide curl options for auth/ports, etc.

There should be an easier way to interrogate WP, Yoast, etc for the sitemap contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment