Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_pydantic_models.py should ignore external modules #17659

Closed
azmeuk opened this issue Sep 4, 2024 · 0 comments · Fixed by #17667
Closed

check_pydantic_models.py should ignore external modules #17659

azmeuk opened this issue Sep 4, 2024 · 0 comments · Fixed by #17667

Comments

@azmeuk
Copy link
Contributor

azmeuk commented Sep 4, 2024

The check_pydantic_models.py script patches all pydantic imports, including the imports from external modules. #17144 introduces a dependency to scim2-models that requires pydantic >= 2.7 and breaks the script.

After discussing it on #synapse-dev, it seems check_pydantic_models.py should ignore external modules.

Related to matrix-org/synapse#13502, matrix-org/synapse#16332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

import pydantic objects from the _pydantic_compat module yaal-coop/synapse
1 participant
@azmeuk