Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventID incorrectly inherits from DomainSpecificString #14638

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

EventID incorrectly inherits from DomainSpecificString #14638

matrixbot opened this issue Dec 20, 2023 · 0 comments
Labels
O-Occasional S-Minor T-Defect Z-Cleanup

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023 •
edited
Loading

This issue has been migrated from #14638.

Not super happy with the startswith but EventID.is_valid is broken for non-V1/2 event IDs so unsure how to proceed.

Originally posted by @Fizzadar in matrix-org/synapse#14632 (comment)

Modern event IDs are now hashes and do not include a domain name, so they shouldn't inherit from DomainSepcificString.
@matrixbot matrixbot changed the title Dummy issue EventID incorrectly inherits from DomainSpecificString Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional S-Minor T-Defect Z-Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot