Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace loggingcontexts with contextvars #10342

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

replace loggingcontexts with contextvars #10342

matrixbot opened this issue Dec 18, 2023 · 0 comments
Labels
A-Logging P3 T-Enhancement

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023 •
edited
Loading

This issue has been migrated from #10342.

logcontexts are super confusing, and easy to mess up.

We should experiment with replacing the thread-local variable we currently use with a contextvar, which Twisted has first-class support for (twisted/twisted#1192), which could potentially save everyone who ever touches Synapse code a great deal of pain.
@matrixbot matrixbot changed the title Dummy issue replace loggingcontexts with contextvars Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Logging P3 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot