Pass the remote_room_hosts as a list instead of a tuple.

Author: sandhose

synapse/handlers/room_summary.py

@@ -118,7 +118,7 @@ def __init__(self, hs: "HomeServer"):
                 Optional[int],
                 Optional[int],
                 Optional[str],
-                Optional[Tuple[str, ...]],
+                Optional[List[str]],
             ]
         ] = ResponseCache(
             hs.get_clock(),
@@ -134,7 +134,7 @@ async def get_room_hierarchy(
         max_depth: Optional[int] = None,
         limit: Optional[int] = None,
         from_token: Optional[str] = None,
-        remote_room_hosts: Optional[Tuple[str, ...]] = None,
+        remote_room_hosts: Optional[List[str]] = None,
     ) -> JsonDict:
         """
         Implementation of the room hierarchy C-S API.
@@ -191,7 +191,7 @@ async def _get_room_hierarchy(
         max_depth: Optional[int] = None,
         limit: Optional[int] = None,
         from_token: Optional[str] = None,
-        remote_room_hosts: Optional[Tuple[str, ...]] = None,
+        remote_room_hosts: Optional[List[str]] = None,
     ) -> JsonDict:
         """See docstring for SpaceSummaryHandler.get_room_hierarchy."""
 
@@ -211,7 +211,7 @@ async def _get_room_hierarchy(
 
         if not local_room:
             room_hierarchy = await self._summarize_remote_room_hierarchy(
-                _RoomQueueEntry(requested_room_id, remote_room_hosts or ()),
+                _RoomQueueEntry(requested_room_id, remote_room_hosts or []),
                 False,
             )
             root_room_entry = room_hierarchy[0]
@@ -252,7 +252,7 @@ async def _get_room_hierarchy(
             processed_rooms = set(pagination_session["processed_rooms"])
         else:
             # The queue of rooms to process, the next room is last on the stack.
-            room_queue = [_RoomQueueEntry(requested_room_id, remote_room_hosts or ())]
+            room_queue = [_RoomQueueEntry(requested_room_id, remote_room_hosts or [])]
 
             # Rooms we have already processed.
             processed_rooms = set()

synapse/rest/client/room.py

@@ -1527,14 +1527,13 @@ async def on_GET(
         max_depth = parse_integer(request, "max_depth")
         limit = parse_integer(request, "limit")
 
-        # twisted.web.server.Request.args is incorrectly defined as Optional[Any]
         remote_room_hosts = None
         if self.msc4235_enabled:
+            # twisted.web.server.Request.args is incorrectly defined as Optional[Any]
             args: Dict[bytes, List[bytes]] = request.args  # type: ignore
-            via_param = parse_strings_from_args(
+            remote_room_hosts = parse_strings_from_args(
                 args, "org.matrix.msc4235.via", required=False
             )
-            remote_room_hosts = tuple(via_param or [])
 
         return 200, await self._room_summary_handler.get_room_hierarchy(
             requester,

tests/handlers/test_room_summary.py

@@ -1088,7 +1088,7 @@ def test_fed_remote_room_hosts(self) -> None:
         fed_space = "#fed_space:" + fed_hostname
         fed_subroom = "#fed_sub_room:" + fed_hostname
 
-        remote_room_hosts = tuple(fed_hostname)
+        remote_room_hosts = [fed_hostname]
 
         requested_room_entry = _RoomEntry(
             fed_space,