Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSS: read receipts are missing #3106

Closed
Tracked by #3647
ara4n opened this issue Aug 1, 2024 · 5 comments
Closed
Tracked by #3647

SSS: read receipts are missing #3106

ara4n opened this issue Aug 1, 2024 · 5 comments
Assignees
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync A-Timeline T-Defect X-Needs-Backend Z-Labs A defect in a feature that is behind a labs flag.

Comments

@ara4n
Copy link
Member

ara4n commented Aug 1, 2024

Steps to reproduce

  1. send a bunch of messages in EX with SSS
  2. feel upset that nobody is reading them
  3. compare with EW, and see that people are reading them.
  4. wonder why some RRs are present, but not recent updates

Outcome

What did you expect?

consistent RRs

What happened instead?

missing RRs

Your phone model

No response

Operating system version

No response

Application version

666

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Aug 1, 2024
@manuroe manuroe added the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 2, 2024
@manuroe
Copy link
Member

manuroe commented Aug 5, 2024

@erikjohnston is it implemented on the backend?

@erikjohnston
Copy link
Member

It is implemented in SSS, and we should be sending down all live receipts. The only time this doesn't happen is if the room comes down with initial flag set, in which case we will only send down receipts that match events in the timeline (and EX sets the timeline limit to 1, so you'd only see receipts on the last message).

So long as the room is in the range (and it should be), then SSS should be sending down all new receipts.

@erikjohnston
Copy link
Member

It does look like the code may be a bit buggy when it comes to rooms coming into the range (it looks like it won't send existing receipts). Though I'd still expect in the case of M sending a message that a) the room will be in range and stay in range, and b) therefore he should see all new receipts.

@pixlwave pixlwave added A-Timeline Z-Labs A defect in a feature that is behind a labs flag. X-Needs-Backend labels Aug 5, 2024
@erikjohnston
Copy link
Member

I think this is exacerbated by the fact the Rust SDK will occasionally reduce its range to [0,19] again and then grow the ranges. However, it can take ages to grow the lists as the SDK sets a timeout and so if there is nothing new in the update range the server will block waiting for updates.

@erikjohnston erikjohnston self-assigned this Aug 14, 2024
@erikjohnston
Copy link
Member

The server should now be correctly sending down read receipts, so hoping this is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync A-Timeline T-Defect X-Needs-Backend Z-Labs A defect in a feature that is behind a labs flag.
Projects
None yet
Development

No branches or pull requests

4 participants