Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSS: duplicated rooms in search results #3105

Open
ara4n opened this issue Aug 1, 2024 · 4 comments
Open

SSS: duplicated rooms in search results #3105

ara4n opened this issue Aug 1, 2024 · 4 comments
Labels
A-Room-List A-SSS Regression or bug observed when using Simplified Sliding Sync X-Needs-Backend Z-Labs A defect in a feature that is behind a labs flag.

Comments

@ara4n
Copy link
Member

ara4n commented Aug 1, 2024

Steps to reproduce

  1. search for a room (on bad data)?
    IMG_7903

  2. see multiple results

  3. i think the duplicated rooms may later disappear if you are on good data?

Outcome

What did you expect?

no duplicate rooms when filtering

What happened instead?

dup rooms

Your phone model

No response

Operating system version

No response

Application version

666

Homeserver

No response

Will you send logs?

No

@manuroe manuroe added the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 2, 2024
@manuroe
Copy link
Member

manuroe commented Aug 5, 2024

There is an issue with tombstoned rooms. @erikjohnston can you check the backend does not send them?

@erikjohnston
Copy link
Member

Ah, we don't filter out tombstoned rooms. Though I thought we had agreed not to, but I can't find where that was said so maybe I misunderstood

@pixlwave pixlwave added Z-Labs A defect in a feature that is behind a labs flag. A-Room-List X-Needs-Backend labels Aug 5, 2024
@manuroe
Copy link
Member

manuroe commented Aug 5, 2024

Tagging @Hywan for visibilty.

@Hywan
Copy link
Member

Hywan commented Aug 8, 2024

@erikjohnston I reckon we said to remove the filter from the public API, but it should be a default on the server side. At least it was my understanding 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-SSS Regression or bug observed when using Simplified Sliding Sync X-Needs-Backend Z-Labs A defect in a feature that is behind a labs flag.
Projects
None yet
Development

No branches or pull requests

5 participants