Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSS: Spurious idle rooms keep surfacing in the roomlist #3096

Open
ara4n opened this issue Jul 27, 2024 · 8 comments
Open

SSS: Spurious idle rooms keep surfacing in the roomlist #3096

ara4n opened this issue Jul 27, 2024 · 8 comments
Labels
A-Room-List A-Simplified-Sliding-Sync A-SSS Regression or bug observed when using Simplified Sliding Sync T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-Labs A defect in a feature that is behind a labs flag.

Comments

@ara4n
Copy link
Member

ara4n commented Jul 27, 2024

Steps to reproduce

  1. Enable SSS on a largeish account
  2. Giggle happily as it syncs roughly as fast as with SS and the proxy
  3. Observe that some random idle room keeps bubbling up near the top of the room list for no obvious reason (!NNtfYnugaAKouPTJdp:matrix.org aka Element Demo in this instance):

IMG_7854

Outcome

What did you expect?

Element Demo should be buried many many pages down the roomlist as there haven’t been any events there for weeks.

What happened instead?

IMG_7855

Your phone model

No response

Operating system version

No response

Application version

663

Homeserver

No response

Will you send logs?

Yes

@ara4n
Copy link
Member Author

ara4n commented Jul 27, 2024

(also, note the timestamp on the conduit room room preview is wonky; looks like the subscribe failed)

@pixlwave pixlwave added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Room-List T-Defect A-Simplified-Sliding-Sync Z-Labs A defect in a feature that is behind a labs flag. labels Jul 30, 2024
@manuroe manuroe added the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 2, 2024
@manuroe
Copy link
Member

manuroe commented Aug 5, 2024

Probably an issue with with the bumpstamp. Likely a backend issue. @erikjohnston can you check the rageshake?

@erikjohnston
Copy link
Member

erikjohnston commented Aug 5, 2024

That room has a bot that sends a m.notice very frequently. Looks like the SDK is desperately trying to paginate back to find a normal message.

My guess is that the rust SDK is not handling that situation particularly well, and TBH I'm not sure what the best way to handle that situation is (i.e. where its broadly impossible to find a bump event).

FTR the room ID is !NNtfYnugaAKouPTJdp:matrix.org. Searching in the rageshake you can clearly see repeated attempts to backpaginate.

@Hywan
Copy link
Member

Hywan commented Aug 14, 2024

The SDK doesn't backpaginate a room automatically. It happens only when the timeline is scrolling to the top as far as I know. cc @bnjbvr can you confirm?

(cc matrix-org/matrix-rust-sdk#3647)

@bnjbvr
Copy link
Member

bnjbvr commented Aug 14, 2024

Backpagination doesn't happen automatically at the moment, but as far as I recall, the EX apps may automatically backpaginate after a room has been entered.

@erikjohnston
Copy link
Member

Huh, I thought I saw the app try and call a lot of /messages, but maybe that was because M had entered the room.

@ara4n
Copy link
Member Author

ara4n commented Aug 24, 2024

empirically if i enter that room, it spins forever and never loads. shouldn't the m.notices be visible? the room doesn't rise to the surface on other clients iirc.

@stefanceriu
Copy link
Member

@ara4n Haven't seen this myself, is is still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-Simplified-Sliding-Sync A-SSS Regression or bug observed when using Simplified Sliding Sync T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-Labs A defect in a feature that is behind a labs flag.
Projects
None yet
Development

No branches or pull requests

7 participants