Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of stripped-emoji.json and improve emojibase performance #9780

Closed
ara4n opened this issue May 21, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3745
Closed

Get rid of stripped-emoji.json and improve emojibase performance #9780

ara4n opened this issue May 21, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3745
Assignees
@t3chguy
Labels
A-Aggregations A-Emoji A-Reactions T-Task Tasks for the team like planning

Comments

@ara4n
Copy link
Member

ara4n commented May 21, 2019

We currently include emojibase's compact.json as well as our weird pregenerated stripped-emoji.json. The latter is redundant and confusing (especially as we were already shipping emojione's various JSON databases); i think we should remove it, ship only compact.json, and then generate the correct in-memory lookups at startup for doing shortcodeToUnicode and unicodeToShortcode etc.

See also matrix-org/matrix-react-sdk@b0ec594 and matrix-org/matrix-react-sdk#2995 (comment).

We should at least revisit this if/when implement emojimart as a picker as per #9484
@ara4n ara4n added the T-Task Tasks for the team like planning label May 21, 2019
@ara4n ara4n changed the title Get rid of stripped-emoji.json Get rid of stripped-emoji.json and improve emojibase performance May 21, 2019
@ara4n ara4n mentioned this issue May 21, 2019
Merged
@jryans jryans added A-Emoji and removed A-Emoji labels May 30, 2019
@npny npny mentioned this issue Jun 5, 2019
Closed
@t3chguy t3chguy self-assigned this Dec 18, 2019
@t3chguy t3chguy mentioned this issue Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Aggregations A-Emoji A-Reactions T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
3 participants
@jryans @ara4n @t3chguy